ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "crash_dump: make output fd O_APPEND." am: a70f11331f

Browse source 
am: 9fcaf5110d

Change-Id: I522958406a39bd249492d54b3a0b940250cef65e
This commit is contained in:
Josh Gao 2017-02-16 22:52:31 +00:00 • committed by android-build-merger
commit 02b1dffe39
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
debuggerd/crash_dump.cpp
View file

@ -155,6 +155,14 @@ static bool tombstoned_connect(pid_t pid, unique_fd* tombstoned_socket, unique_f
return false;
}
// Make the fd O_APPEND so that our output is guaranteed to be at the end of a file.
// (This also makes selinux rules consistent, because selinux distinguishes between writing to
// a regular fd, and writing to an fd with O_APPEND).
int flags = fcntl(tmp_output_fd.get(), F_GETFL);
if (fcntl(tmp_output_fd.get(), F_SETFL, flags | O_APPEND) != 0) {
PLOG(WARNING) << "failed to set output fd flags";
}
*tombstoned_socket = std::move(sockfd);
*output_fd = std::move(tmp_output_fd);
return true;