From 042c3d406a970100dfd024dc10bc5af3e030b297 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 8 Apr 2014 14:34:04 -0400 Subject: [PATCH] crash_sender: log product info in new list format The 00A0 unicode space hack hasn't been reliable. The latest Chromium code supports a 3rd field in the crash list though, so let's use that instead. The UI has already been updated to look for this: https://codereview.chromium.org/219383008/ BUG=chromium:210624 TEST=logged a system crash and looked at crashes page TEST=logged a chrome crash and looked at crashes page TEST=`cbuildbot {x86,amd64}-generic-full` pass (VMTests) Change-Id: Icce0d9d26276143a1604b8eef5c68a2a6417c912 Reviewed-on: https://chromium-review.googlesource.com/193611 Reviewed-by: Mike Frysinger Commit-Queue: Mike Frysinger Tested-by: Mike Frysinger --- crash_reporter/crash_sender | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/crash_reporter/crash_sender b/crash_reporter/crash_sender index 3b4f18361..9dcf34631 100755 --- a/crash_reporter/crash_sender +++ b/crash_reporter/crash_sender @@ -460,14 +460,22 @@ send_crash() { local product_name local timestamp="$(date +%s)" case ${product} in - Chrome_ChromeOS) + Chrome_ChromeOS) + if is_official_image; then product_name="Chrome" - ;; - *) + else + product_name="Chromium" + fi + ;; + *) + if is_official_image; then product_name="ChromeOS" - ;; + else + product_name="ChromiumOS" + fi + ;; esac - /usr/bin/printf '%s,%s\u00A0(%s)\n' \ + printf '%s,%s,%s\n' \ "${timestamp}" "${id}" "${product_name}" >> "${CHROME_CRASH_LOG}" lecho "Crash report receipt ID ${id}" else