ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Remove unused logging symbols."

Browse source
This commit is contained in:
Tomasz Wasilczyk 2018-08-01 16:37:38 +00:00 • committed by Gerrit Code Review
commit 081b710b2e
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
base/include/android-base/logging.h
View file

@ -447,11 +447,6 @@ class LogMessage {
private:
const std::unique_ptr<LogMessageData> data_;
// TODO(b/35361699): remove these symbols once all prebuilds stop using it.
LogMessage(const char* file, unsigned int line, LogId id, LogSeverity severity, int error);
static void LogLine(const char* file, unsigned int line, LogId id, LogSeverity severity,
const char* msg);
DISALLOW_COPY_AND_ASSIGN(LogMessage);
};

9
base/logging.cpp
View file

@ -410,10 +410,6 @@ LogMessage::LogMessage(const char* file, unsigned int line, LogId id, LogSeverit
const char* tag, int error)
: data_(new LogMessageData(file, line, id, severity, tag, error)) {}
LogMessage::LogMessage(const char* file, unsigned int line, LogId id, LogSeverity severity,
int error)
: LogMessage(file, line, id, severity, nullptr, error) {}
LogMessage::~LogMessage() {
// Check severity again. This is duplicate work wrt/ LOG macros, but not LOG_STREAM.
if (!WOULD_LOG(data_->GetSeverity())) {
@ -470,11 +466,6 @@ void LogMessage::LogLine(const char* file, unsigned int line, LogId id, LogSever
}
}
void LogMessage::LogLine(const char* file, unsigned int line, LogId id, LogSeverity severity,
const char* message) {
LogLine(file, line, id, severity, nullptr, message);
}
LogSeverity GetMinimumLogSeverity() {
return gMinimumLogSeverity;
}