From 3aac36201bc75159cfa801f92765574ce1c77636 Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Fri, 18 Oct 2024 21:51:45 +0000 Subject: [PATCH] Remove log spam. When dumping, the code checks if a thread is running as a guest. If it's not, the code always logs an error message if the header data structure cannot be read. Don't print an error message in this case. Test: Crash and no longer see "failed to get the guest state header" Test: message. Change-Id: I6971b57b218a4f653682cfdc82118dc576d9e331 --- debuggerd/crash_dump.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/debuggerd/crash_dump.cpp b/debuggerd/crash_dump.cpp index c9235eeff..15e8319a9 100644 --- a/debuggerd/crash_dump.cpp +++ b/debuggerd/crash_dump.cpp @@ -470,14 +470,12 @@ static bool GetGuestRegistersFromCrashedProcess([[maybe_unused]] pid_t tid, } NativeBridgeGuestStateHeader header; - if (!process_memory->ReadFully(header_ptr, &header, sizeof(NativeBridgeGuestStateHeader))) { - PLOG(ERROR) << "failed to get the guest state header for thread " << tid; - return false; - } - if (header.signature != NATIVE_BRIDGE_GUEST_STATE_SIGNATURE) { + if (!process_memory->ReadFully(header_ptr, &header, sizeof(NativeBridgeGuestStateHeader)) || + header.signature != NATIVE_BRIDGE_GUEST_STATE_SIGNATURE) { // Return when ptr points to unmapped memory or no valid guest state. return false; } + auto guest_state_data_copy = std::make_unique(header.guest_state_data_size); if (!process_memory->ReadFully(reinterpret_cast(header.guest_state_data), guest_state_data_copy.get(), header.guest_state_data_size)) {