From 447b4a4bf032a550ada6621a33d6b1e188357eb2 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Tue, 6 Jun 2023 17:52:39 +0000 Subject: [PATCH] libcutils_test: static libjsoncpp The 32-bit variant of libjsoncpp is not always installed on 64-bit devices, so it must always be statically included. We should probably collapse libcutils_test with libcutils_test_static in the future. Bug: 285357054 Test: libcutils_test Merged-In: Ic84901ce5af766338b2cab07c3cf10841ba9a150 Change-Id: Ic84901ce5af766338b2cab07c3cf10841ba9a150 --- libcutils/Android.bp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcutils/Android.bp b/libcutils/Android.bp index 68b21c6a0..b9e0bb7ee 100644 --- a/libcutils/Android.bp +++ b/libcutils/Android.bp @@ -302,11 +302,14 @@ cc_defaults { ], } +always_static_test_libraries = [ + "libjsoncpp", +] + test_libraries = [ "libcutils", "liblog", "libbase", - "libjsoncpp", "libprocessgroup", "libcgrouprc", ] @@ -317,6 +320,7 @@ cc_test { defaults: ["libcutils_test_default"], host_supported: true, shared_libs: test_libraries, + static_libs: always_static_test_libraries, require_root: true, } @@ -326,7 +330,7 @@ cc_defaults { static_libs: [ "libc", "libcgrouprc_format", - ] + test_libraries, + ] + test_libraries + always_static_test_libraries, stl: "libc++_static", require_root: true,