diff --git a/healthd/Android.bp b/healthd/Android.bp index 14d46b3d3..65eaedd90 100644 --- a/healthd/Android.bp +++ b/healthd/Android.bp @@ -240,3 +240,20 @@ cc_test { defaults: ["charger_defaults"], srcs: ["charger_test.cpp"], } + +cc_test { + name: "libhealthd_charger_test", + srcs: ["AnimationParser_test.cpp"], + shared_libs: [ + "liblog", + "libbase", + "libcutils", + ], + static_libs: [ + "libhealthd_charger", + ], + test_suites: [ + "general-tests", + "device-tests", + ], +} diff --git a/healthd/AnimationParser.cpp b/healthd/AnimationParser.cpp index fde3b95e0..6b08570d9 100644 --- a/healthd/AnimationParser.cpp +++ b/healthd/AnimationParser.cpp @@ -37,8 +37,8 @@ bool can_ignore_line(const char* str) { return true; } -bool remove_prefix(const std::string& line, const char* prefix, const char** rest) { - const char* str = line.c_str(); +bool remove_prefix(std::string_view line, const char* prefix, const char** rest) { + const char* str = line.data(); int start; char c; diff --git a/healthd/AnimationParser.h b/healthd/AnimationParser.h index bc0084518..f55b5635e 100644 --- a/healthd/AnimationParser.h +++ b/healthd/AnimationParser.h @@ -17,6 +17,8 @@ #ifndef HEALTHD_ANIMATION_PARSER_H #define HEALTHD_ANIMATION_PARSER_H +#include + #include "animation.h" namespace android { @@ -24,7 +26,7 @@ namespace android { bool parse_animation_desc(const std::string& content, animation* anim); bool can_ignore_line(const char* str); -bool remove_prefix(const std::string& str, const char* prefix, const char** rest); +bool remove_prefix(std::string_view str, const char* prefix, const char** rest); bool parse_text_field(const char* in, animation::text_field* field); } // namespace android diff --git a/healthd/tests/AnimationParser_test.cpp b/healthd/AnimationParser_test.cpp similarity index 100% rename from healthd/tests/AnimationParser_test.cpp rename to healthd/AnimationParser_test.cpp diff --git a/healthd/TEST_MAPPING b/healthd/TEST_MAPPING new file mode 100644 index 000000000..5893d10c7 --- /dev/null +++ b/healthd/TEST_MAPPING @@ -0,0 +1,7 @@ +{ + "presubmit": [ + { + "name": "libhealthd_charger_test" + } + ] +} diff --git a/healthd/tests/Android.mk b/healthd/tests/Android.mk deleted file mode 100644 index 87e8862d0..000000000 --- a/healthd/tests/Android.mk +++ /dev/null @@ -1,21 +0,0 @@ -# Copyright 2016 The Android Open Source Project - -LOCAL_PATH:= $(call my-dir) - -include $(CLEAR_VARS) - -LOCAL_SRC_FILES := \ - AnimationParser_test.cpp \ - -LOCAL_MODULE := healthd_test -LOCAL_MODULE_TAGS := tests - -LOCAL_STATIC_LIBRARIES := \ - libhealthd_internal \ - -LOCAL_SHARED_LIBRARIES := \ - liblog \ - libbase \ - libcutils \ - -include $(BUILD_NATIVE_TEST)