From 5169c167c5ab026e80437c4f54bd4486549a782e Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Tue, 24 Oct 2017 12:39:10 -0700 Subject: [PATCH] Remove PauseTiming/ResumeTiming calls. These calls can only be used after the call to state.KeepRunning(), which handles the start/stop itself. Bug: 68170209 Test: Ran the benchmark and got reasonable results. Change-Id: Ie12eb3a983f6fe60c85d6dfc90957eedc16b5526 --- libbacktrace/backtrace_benchmarks.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/libbacktrace/backtrace_benchmarks.cpp b/libbacktrace/backtrace_benchmarks.cpp index 30c2a55ce..aa1662fb1 100644 --- a/libbacktrace/backtrace_benchmarks.cpp +++ b/libbacktrace/backtrace_benchmarks.cpp @@ -70,7 +70,6 @@ static bool CountMaps(pid_t pid, size_t* num_maps) { } static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t, bool)) { - state.PauseTiming(); // Create a remote process so that the map data is exactly the same. // Also, so that we can create a set number of maps. pid_t pid; @@ -132,7 +131,6 @@ static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t, return; } - state.ResumeTiming(); while (state.KeepRunning()) { for (size_t i = 0; i < static_cast(state.range(0)); i++) { BacktraceMap* map = map_func(pid, false); @@ -143,7 +141,6 @@ static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t, delete map; } } - state.PauseTiming(); kill(pid, SIGKILL); waitpid(pid, nullptr, 0);