From eb7ec7b9e8880a3d7dcf8a737f9f3401d5cde55b Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Mon, 26 Sep 2022 22:14:43 +0900 Subject: [PATCH] Annotate symbols correctly Currently, tagging a symbol with #apex (# systemapi or # llndk) is not required when the symbol is in a non-NDK library. However, this is considered dangerous because such a symbol will automatically be promoted to NDK APIs when the library is promoted to an NDK library. When that happens, the native API council won't be able to notice the promotion because promoting a non-NDK library into an NDK library doesn't require an update of the map.txt file, but Android.bp only. To prevent that, we should mandate those tags for Mainline APIs regardless of whether the library the API belongs to is an NDK library or not. Upcoming changes in build/soong will enforce this. This change is to prepare for the enforcement. Note that this is a build-time only change. There's no behavior change at runtime. Bug: 184712170 Test: m Change-Id: I769c5318e0cfd092f2f2b368f1a860065c79818f --- libprocessgroup/cgrouprc/libcgrouprc.map.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libprocessgroup/cgrouprc/libcgrouprc.map.txt b/libprocessgroup/cgrouprc/libcgrouprc.map.txt index ce5c419a3..b62b10f3b 100644 --- a/libprocessgroup/cgrouprc/libcgrouprc.map.txt +++ b/libprocessgroup/cgrouprc/libcgrouprc.map.txt @@ -1,18 +1,18 @@ LIBCGROUPRC { # introduced=29 global: - ACgroupFile_getVersion; - ACgroupFile_getControllerCount; - ACgroupFile_getController; - ACgroupController_getVersion; - ACgroupController_getName; - ACgroupController_getPath; + ACgroupFile_getVersion; # llndk systemapi + ACgroupFile_getControllerCount; # llndk systemapi + ACgroupFile_getController; # llndk systemapi + ACgroupController_getVersion; # llndk systemapi + ACgroupController_getName; # llndk systemapi + ACgroupController_getPath; # llndk systemapi local: *; }; LIBCGROUPRC_30 { # introduced=30 global: - ACgroupController_getFlags; + ACgroupController_getFlags; # llndk systemapi local: *; };