diff --git a/init/action.cpp b/init/action.cpp index ccc18cf9e..acbb12e8e 100644 --- a/init/action.cpp +++ b/init/action.cpp @@ -105,7 +105,10 @@ std::size_t Action::NumCommands() const { } void Action::ExecuteOneCommand(std::size_t command) const { - ExecuteCommand(commands_[command]); + // We need a copy here since some Command execution may result in + // changing commands_ vector by importing .rc files through parser + Command cmd = commands_[command]; + ExecuteCommand(cmd); } void Action::ExecuteAllCommands() const { @@ -118,14 +121,16 @@ void Action::ExecuteCommand(const Command& command) const { Timer t; int result = command.InvokeFunc(); - // TODO: this should probably be changed to "if (failed || took a long time)"... - if (android::base::GetMinimumLogSeverity() <= android::base::DEBUG) { + double duration_ms = t.duration() * 1000; + // Any action longer than 50ms will be warned to user as slow operation + if (duration_ms > 50.0 || + android::base::GetMinimumLogSeverity() <= android::base::DEBUG) { std::string trigger_name = BuildTriggersString(); std::string cmd_str = command.BuildCommandString(); std::string source = command.BuildSourceString(); LOG(INFO) << "Command '" << cmd_str << "' action=" << trigger_name << source - << " returned " << result << " took " << t.duration() << "s"; + << " returned " << result << " took " << duration_ms << "ms."; } } diff --git a/init/builtins.cpp b/init/builtins.cpp index 08b591b5c..8042bfd65 100644 --- a/init/builtins.cpp +++ b/init/builtins.cpp @@ -589,9 +589,9 @@ static int do_mount_all(const std::vector& args) { for (na = args.size() - 1; na > 1; --na) { if (args[na] == "--early") { - path_arg_end = na; - queue_event = false; - mount_mode = MOUNT_MODE_EARLY; + path_arg_end = na; + queue_event = false; + mount_mode = MOUNT_MODE_EARLY; } else if (args[na] == "--late") { path_arg_end = na; import_rc = false;