From 2c6b83f4d26d370f0a42701a6160720f4b1223e4 Mon Sep 17 00:00:00 2001 From: "sanga1.lee" Date: Mon, 22 Apr 2024 15:45:46 +0900 Subject: [PATCH] setprop: check if not setprop value but setprop name starts with "ro." When setting property with setprop, a property name which starts with "ro." could be set no matter how long the value name is. Change-Id: Ia035ef009952db08ae8a6d4a2b8b9567d86124fc --- toolbox/setprop.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolbox/setprop.cpp b/toolbox/setprop.cpp index acf8c3e61..91edf4591 100644 --- a/toolbox/setprop.cpp +++ b/toolbox/setprop.cpp @@ -58,7 +58,7 @@ extern "C" int setprop_main(int argc, char** argv) { } } - if (value.size() >= PROP_VALUE_MAX && !StartsWith(value, "ro.")) { + if (value.size() >= PROP_VALUE_MAX && !StartsWith(name, "ro.")) { std::cerr << "Value '" << value << "' is too long, " << value.size() << " bytes vs a max of " << PROP_VALUE_MAX << std::endl; return EXIT_FAILURE;