From 2da7808bad3ddb8ccf2110824df173b13ab83b59 Mon Sep 17 00:00:00 2001 From: Mitchell Wills Date: Mon, 8 May 2023 13:12:45 -0700 Subject: [PATCH] Fix the return values of DmTable::valid to match the expected type Test: make libdm Change-Id: Id2be81eafe5168be9bfb37a5bcabfbdba3de8fa7 --- fs_mgr/libdm/dm_table.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs_mgr/libdm/dm_table.cpp b/fs_mgr/libdm/dm_table.cpp index efe03ab1e..b546995fc 100644 --- a/fs_mgr/libdm/dm_table.cpp +++ b/fs_mgr/libdm/dm_table.cpp @@ -38,11 +38,11 @@ bool DmTable::RemoveTarget(std::unique_ptr&& /* target */) { bool DmTable::valid() const { if (targets_.empty()) { LOG(ERROR) << "Device-mapper table must have at least one target."; - return ""; + return false; } if (targets_[0]->start() != 0) { LOG(ERROR) << "Device-mapper table must start at logical sector 0."; - return ""; + return false; } return true; }