From c205f585e75d233ca628fd294eaa391a4757de97 Mon Sep 17 00:00:00 2001 From: Yifan Hong Date: Wed, 28 Aug 2019 15:55:58 -0700 Subject: [PATCH] liblp: convert more functions to use string_view (#3) Test: builds Change-Id: Ia448993ff61d46ae2280e3d3c02b5e84dd51f37c --- fs_mgr/liblp/builder.cpp | 2 +- fs_mgr/liblp/include/liblp/builder.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs_mgr/liblp/builder.cpp b/fs_mgr/liblp/builder.cpp index c91fbe4e9..f8c492d2a 100644 --- a/fs_mgr/liblp/builder.cpp +++ b/fs_mgr/liblp/builder.cpp @@ -426,7 +426,7 @@ bool MetadataBuilder::Init(const std::vector& block_devices, return true; } -bool MetadataBuilder::AddGroup(const std::string& group_name, uint64_t maximum_size) { +bool MetadataBuilder::AddGroup(std::string_view group_name, uint64_t maximum_size) { if (FindGroup(group_name)) { LERROR << "Group already exists: " << group_name; return false; diff --git a/fs_mgr/liblp/include/liblp/builder.h b/fs_mgr/liblp/include/liblp/builder.h index e3b591a72..5ab42f56e 100644 --- a/fs_mgr/liblp/include/liblp/builder.h +++ b/fs_mgr/liblp/include/liblp/builder.h @@ -91,7 +91,7 @@ class PartitionGroup final { friend class MetadataBuilder; public: - explicit PartitionGroup(const std::string& name, uint64_t maximum_size) + explicit PartitionGroup(std::string_view name, uint64_t maximum_size) : name_(name), maximum_size_(maximum_size) {} const std::string& name() const { return name_; } @@ -206,7 +206,7 @@ class MetadataBuilder { // total space used by all partitions in the group. // // This can fail and return false if the group already exists. - bool AddGroup(const std::string& group_name, uint64_t maximum_size); + bool AddGroup(std::string_view group_name, uint64_t maximum_size); // Export metadata so it can be serialized to an image, to disk, or mounted // via device-mapper.