From 3336c7bce087d33cc9ab0b02139b39551539f8a6 Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Mon, 8 Apr 2019 17:18:24 -0700 Subject: [PATCH] Remove include of backtrace/Backtrace.h. Somehow the code was still including this include from libbacktrace. I think the libbacktrace include directory was coming from some transitive includes. I verified that nothing in debuggerd is using the libbacktace.so shared library. Bug: 120606663 Test: Builds, unit tests pass. Change-Id: I85c2837c5a539ccefc5a7140949988058d21697a --- debuggerd/libdebuggerd/include/libdebuggerd/utility.h | 10 +++++++++- debuggerd/libdebuggerd/test/tombstone_test.cpp | 1 + debuggerd/libdebuggerd/tombstone.cpp | 1 + debuggerd/libdebuggerd/utility.cpp | 1 - 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/debuggerd/libdebuggerd/include/libdebuggerd/utility.h b/debuggerd/libdebuggerd/include/libdebuggerd/utility.h index 7c5304e84..238c00c5d 100644 --- a/debuggerd/libdebuggerd/include/libdebuggerd/utility.h +++ b/debuggerd/libdebuggerd/include/libdebuggerd/utility.h @@ -18,6 +18,7 @@ #ifndef _DEBUGGERD_UTILITY_H #define _DEBUGGERD_UTILITY_H +#include #include #include #include @@ -25,7 +26,6 @@ #include #include -#include struct log_t { // Tombstone file descriptor. @@ -61,6 +61,14 @@ enum logtype { OPEN_FILES }; +#if defined(__LP64__) +#define PRIPTR "016" PRIx64 +typedef uint64_t word_t; +#else +#define PRIPTR "08" PRIx64 +typedef uint32_t word_t; +#endif + // Log information onto the tombstone. void _LOG(log_t* log, logtype ltype, const char* fmt, ...) __attribute__((format(printf, 3, 4))); diff --git a/debuggerd/libdebuggerd/test/tombstone_test.cpp b/debuggerd/libdebuggerd/test/tombstone_test.cpp index eed5bd30f..3196ce84b 100644 --- a/debuggerd/libdebuggerd/test/tombstone_test.cpp +++ b/debuggerd/libdebuggerd/test/tombstone_test.cpp @@ -15,6 +15,7 @@ */ #include +#include #include #include diff --git a/debuggerd/libdebuggerd/tombstone.cpp b/debuggerd/libdebuggerd/tombstone.cpp index 47a7a8ff8..cc337ed30 100644 --- a/debuggerd/libdebuggerd/tombstone.cpp +++ b/debuggerd/libdebuggerd/tombstone.cpp @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include diff --git a/debuggerd/libdebuggerd/utility.cpp b/debuggerd/libdebuggerd/utility.cpp index d0c5234d3..7aebea8fe 100644 --- a/debuggerd/libdebuggerd/utility.cpp +++ b/debuggerd/libdebuggerd/utility.cpp @@ -35,7 +35,6 @@ #include #include #include -#include #include #include #include