ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

logd: fix bad test assumptions

Browse source 
SerializedLogChunk.three_logs assumes that log buffers are
zero-initialized, but they are not.  This causes test failures on
host.

Test: this test passes
Change-Id: I0dfa282bdc36eaa4e8e39d85c5227f717b45ec2a
This commit is contained in:
Tom Cherry 2020-10-06 15:54:26 -07:00
parent 1bacb2c389
commit 340afd38cb
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
logd/SerializedLogChunkTest.cpp
View file

@ -99,13 +99,9 @@ TEST(SerializedLogChunk, three_logs) {
"\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF" // Timestamp
"\x0C\x00last message"; // msg_len + message
for (size_t i = 0; i < chunk_size; ++i) {
if (i < sizeof(expected_buffer_data)) {
EXPECT_EQ(static_cast<uint8_t>(expected_buffer_data[i]), chunk.data()[i])
<< "position: " << i;
} else {
EXPECT_EQ(0, chunk.data()[i]) << "position: " << i;
}
for (size_t i = 0; i < sizeof(expected_buffer_data); ++i) {
EXPECT_EQ(static_cast<uint8_t>(expected_buffer_data[i]), chunk.data()[i])
<< "position: " << i;
}
}