ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

crash_collector: add /crash to the user crash path

Browse source 
The recent multiprofile work forgot to append /crash to the user-specific
crash path.  It was in the fallback path, but not the dynamic one.

BUG=chromium:248629
TEST=`cros_run_unit_tests --board=x86-alex -p crash-reporter` works
TEST=`cbuildbot x86-generic-full` works

Change-Id: If87848526b0e78f3f76fd412b0f46e37b7022bd6
Reviewed-on: https://gerrit.chromium.org/gerrit/58232
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Frysinger 2013-06-11 17:03:59 -04:00 • committed by ChromeBot
parent 20980d71ee
commit 37843a9f8a
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crash_reporter/crash_collector.cc
View file

@ -196,7 +196,8 @@ FilePath CrashCollector::GetUserCrashPath(void) {
GList *list = g_hash_table_get_values(active_sessions);
if (list) {
const char *salted_path = static_cast<const char *>(list->data);
user_path = chromeos::cryptohome::home::GetHashedUserPath(salted_path);
user_path = chromeos::cryptohome::home::GetHashedUserPath(salted_path)
.Append("crash");
g_list_free(list);
}

2
crash_reporter/crash_collector_test.cc
View file

@ -139,7 +139,7 @@ TEST_F(CrashCollectorTest, GetCrashDirectoryInfo) {
&directory_mode,
&directory_owner,
&directory_group);
EXPECT_EQ("/home/user/hashcakes", path.value());
EXPECT_EQ("/home/user/hashcakes/crash", path.value());
EXPECT_EQ(kExpectedUserMode, directory_mode);
EXPECT_EQ(kChronosUid, directory_owner);
EXPECT_EQ(kChronosGid, directory_group);