ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Fix heap-buffer-overflow detected by ASAN."

Browse source
This commit is contained in:
Treehugger Robot 2017-03-15 06:46:27 +00:00 • committed by Gerrit Code Review
commit 3d028f14c8
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
logd/LogBuffer.cpp
View file

@ -180,8 +180,13 @@ static enum match_type identical(LogBufferElement* elem,
if (!avcr) return DIFFERENT; if (!avcr) return DIFFERENT;
lenr -= avcr - msgr; lenr -= avcr - msgr;
if (lenl != lenr) return DIFFERENT; if (lenl != lenr) return DIFFERENT;
if (fastcmp<memcmp>(avcl + strlen(avc), avcr + strlen(avc), lenl)) // TODO: After b/35468874 is addressed, revisit "lenl > strlen(avc)"
// condition, it might become superflous.
if (lenl > strlen(avc) &&
fastcmp<memcmp>(avcl + strlen(avc), avcr + strlen(avc),
lenl - strlen(avc))) {
return DIFFERENT; return DIFFERENT;
}
return SAME; return SAME;
} }