From 3e6d3319b2b131ebdeb831f248dbb8dc72e68c83 Mon Sep 17 00:00:00 2001 From: Natalie Silvanovich Date: Wed, 30 Apr 2014 14:50:27 -0700 Subject: [PATCH] NULL check in registerListener Prevents crash in batteryproperties. Now with two times as much NULL checking. Bug: 13730158 Change-Id: Ica083da60c6543431c2d82d46aed48eaccc3b4b4 --- healthd/BatteryPropertiesRegistrar.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/healthd/BatteryPropertiesRegistrar.cpp b/healthd/BatteryPropertiesRegistrar.cpp index 58da4ee92..272b6d7e2 100644 --- a/healthd/BatteryPropertiesRegistrar.cpp +++ b/healthd/BatteryPropertiesRegistrar.cpp @@ -43,6 +43,8 @@ void BatteryPropertiesRegistrar::notifyListeners(struct BatteryProperties props) void BatteryPropertiesRegistrar::registerListener(const sp& listener) { { + if (listener == NULL) + return; Mutex::Autolock _l(mRegistrationLock); // check whether this is a duplicate for (size_t i = 0; i < mListeners.size(); i++) { @@ -58,6 +60,8 @@ void BatteryPropertiesRegistrar::registerListener(const sp& listener) { + if (listener == NULL) + return; Mutex::Autolock _l(mRegistrationLock); for (size_t i = 0; i < mListeners.size(); i++) { if (mListeners[i]->asBinder() == listener->asBinder()) {