Merge "libsnapshot: Export COW image size" into rvc-dev

This commit is contained in:
Alessio Balsini 2020-05-31 12:20:46 +00:00 committed by Android (Google) Code Review
commit 3ec696d0ce
5 changed files with 29 additions and 2 deletions

View file

@ -140,4 +140,7 @@ message SnapshotMergeReport {
// Number of reboots that occurred after issuing and before completeing the // Number of reboots that occurred after issuing and before completeing the
// merge of all the snapshot devices. // merge of all the snapshot devices.
int32 resume_count = 2; int32 resume_count = 2;
// Total size of all the COW images before the update.
uint64 cow_file_size = 4;
} }

View file

@ -148,7 +148,7 @@ class SnapshotManager final {
// Initiate a merge on all snapshot devices. This should only be used after an // Initiate a merge on all snapshot devices. This should only be used after an
// update has been marked successful after booting. // update has been marked successful after booting.
bool InitiateMerge(); bool InitiateMerge(uint64_t* cow_file_size = nullptr);
// Perform any necessary post-boot actions. This should be run soon after // Perform any necessary post-boot actions. This should be run soon after
// /data is mounted. // /data is mounted.

View file

@ -31,6 +31,8 @@ class SnapshotMergeStats {
// Called when merge starts or resumes. // Called when merge starts or resumes.
bool Start(); bool Start();
void set_state(android::snapshot::UpdateState state); void set_state(android::snapshot::UpdateState state);
virtual void set_cow_file_size(uint64_t cow_file_size);
virtual uint64_t cow_file_size();
// Called when merge ends. Properly clean up permanent storage. // Called when merge ends. Properly clean up permanent storage.
class Result { class Result {
@ -43,6 +45,8 @@ class SnapshotMergeStats {
std::unique_ptr<Result> Finish(); std::unique_ptr<Result> Finish();
private: private:
virtual ~SnapshotMergeStats() {}
bool ReadState(); bool ReadState();
bool WriteState(); bool WriteState();
bool DeleteState(); bool DeleteState();

View file

@ -555,7 +555,7 @@ bool SnapshotManager::DeleteSnapshot(LockedFile* lock, const std::string& name)
return true; return true;
} }
bool SnapshotManager::InitiateMerge() { bool SnapshotManager::InitiateMerge(uint64_t* cow_file_size) {
auto lock = LockExclusive(); auto lock = LockExclusive();
if (!lock) return false; if (!lock) return false;
@ -618,6 +618,7 @@ bool SnapshotManager::InitiateMerge() {
} }
} }
uint64_t total_cow_file_size = 0;
DmTargetSnapshot::Status initial_target_values = {}; DmTargetSnapshot::Status initial_target_values = {};
for (const auto& snapshot : snapshots) { for (const auto& snapshot : snapshots) {
DmTargetSnapshot::Status current_status; DmTargetSnapshot::Status current_status;
@ -627,6 +628,16 @@ bool SnapshotManager::InitiateMerge() {
initial_target_values.sectors_allocated += current_status.sectors_allocated; initial_target_values.sectors_allocated += current_status.sectors_allocated;
initial_target_values.total_sectors += current_status.total_sectors; initial_target_values.total_sectors += current_status.total_sectors;
initial_target_values.metadata_sectors += current_status.metadata_sectors; initial_target_values.metadata_sectors += current_status.metadata_sectors;
SnapshotStatus snapshot_status;
if (!ReadSnapshotStatus(lock.get(), snapshot, &snapshot_status)) {
return false;
}
total_cow_file_size += snapshot_status.cow_file_size();
}
if (cow_file_size) {
*cow_file_size = total_cow_file_size;
} }
SnapshotUpdateStatus initial_status; SnapshotUpdateStatus initial_status;

View file

@ -88,6 +88,15 @@ void SnapshotMergeStats::set_state(android::snapshot::UpdateState state) {
report_.set_state(state); report_.set_state(state);
} }
void SnapshotMergeStats::set_cow_file_size(uint64_t cow_file_size) {
report_.set_cow_file_size(cow_file_size);
WriteState();
}
uint64_t SnapshotMergeStats::cow_file_size() {
return report_.cow_file_size();
}
class SnapshotMergeStatsResultImpl : public SnapshotMergeStats::Result { class SnapshotMergeStatsResultImpl : public SnapshotMergeStats::Result {
public: public:
SnapshotMergeStatsResultImpl(const SnapshotMergeReport& report, SnapshotMergeStatsResultImpl(const SnapshotMergeReport& report,