From e3530471bf69c2326baed3a6865e396822522c7b Mon Sep 17 00:00:00 2001 From: Xinyu Chen Date: Sun, 16 Aug 2009 22:09:18 +0800 Subject: [PATCH] Fix bug of mmc.c not checking read_file result. This bug causes segment fault when reading name node of SDIO mmc device's /sys file, which is not existed at all. Signed-off-by: Xinyu Chen --- vold/mmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vold/mmc.c b/vold/mmc.c index fcf7c2f9e..6ad97f439 100644 --- a/vold/mmc.c +++ b/vold/mmc.c @@ -158,6 +158,10 @@ static int mmc_bootstrap_card(char *sysfs_path) sprintf(filename, "/sys%s/name", devpath); p = read_file(filename, &sz); + if (!p) { + LOGE("Unable to read MMC name: %s", filename); + return -errno; + } p[strlen(p) - 1] = '\0'; sprintf(tmp, "MMC_NAME=%s", p); free(p);