ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

OTA: make lp_metadata write more atomic

Browse source 
Powerloss of OS failure occurs when super is merging,
then the device can't bring up again for no lp_metadata sync,
so make lp_metadata sync in time.

Change-Id: I1ea31662b838e35022a566b614796f2d5e05df4b
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
This commit is contained in:
Zhou Xuezan 2023-01-17 11:32:40 +08:00 • committed by Jia Jia
parent 06a150b9f5
commit 45eee7fe52
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
fs_mgr/libfiemap/metadata.cpp
View file

@ -30,6 +30,7 @@ namespace android {
namespace fiemap {
using namespace android::fs_mgr;
using android::base::unique_fd;
static constexpr uint32_t kMaxMetadataSize = 256 * 1024;
@ -109,10 +110,18 @@ bool SaveMetadata(MetadataBuilder* builder, const std::string& metadata_dir) {
if (exported->partitions.empty() && android::base::RemoveFileIfExists(metadata_file)) {
return true;
}
if (!WriteToImageFile(metadata_file, *exported.get())) {
unique_fd fd(open(metadata_file.c_str(), O_CREAT | O_RDWR | O_TRUNC | O_CLOEXEC | O_BINARY | O_SYNC, 0644));
if (fd < 0) {
LOG(ERROR) << "open failed: " << metadata_file;
return false;
}
if (!WriteToImageFile(fd, *exported.get())) {
LOG(ERROR) << "Unable to save new metadata";
return false;
}
return true;
}