ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libsnapshot: Fix some minor formatting bugs

Browse source 
A few minor issues snuck through code review.
Removed a debug line in cow_api_test to persist file.
Removed unused function declaration for cow writer
Switched PLOG to LOG where no errno exists.

Change-Id: Ibb774d6de518fc2a8746e4b9eefc3655c9973c30
Bug: 168554689
Test: cow_api_test
This commit is contained in:
Daniel Rosenberg 2020-11-02 21:47:56 -08:00
parent 0248561ae6
commit 46ef7595d0
3 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
fs_mgr/libsnapshot/cow_api_test.cpp
View file

@ -272,7 +272,6 @@ TEST_F(CowTest, GetSize) {
}
TEST_F(CowTest, Append) {
cow_->DoNotRemove();
CowOptions options;
auto writer = std::make_unique<CowWriter>(options);
ASSERT_TRUE(writer->Initialize(cow_->fd));

2
fs_mgr/libsnapshot/cow_writer.cpp
View file

@ -247,7 +247,7 @@ bool CowWriter::OpenForAppend(uint64_t label) {
}
if (!found_label) {
PLOG(ERROR) << "Failed to find last label";
LOG(ERROR) << "Failed to find last label";
return false;
}

1
fs_mgr/libsnapshot/include/libsnapshot/cow_writer.h
View file

@ -114,7 +114,6 @@ class CowWriter : public ICowWriter {
bool OpenForWrite();
bool OpenForAppend();
bool OpenForAppend(uint64_t label);
bool ImportOps(std::unique_ptr<ICowOpIter> iter);
bool GetDataPos(uint64_t* pos);
bool WriteRawData(const void* data, size_t size);
bool WriteOperation(const CowOperation& op, const void* data = nullptr, size_t size = 0);