From 15d09854a8b2a1adf2fa5123ff77b9882afd6c22 Mon Sep 17 00:00:00 2001 From: David 'Digit' Turner Date: Fri, 21 Jan 2011 19:25:51 +0100 Subject: [PATCH] libsysutils: Fix a file descriptor leak. The recent refactoring of the select() loop in SocketListener missed a close() of the file descriptor when the onDataAvailable() callback returns false. Change-Id: I767caefab4b98ab350f2db2497ee2bd630f20850 --- libsysutils/src/SocketListener.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libsysutils/src/SocketListener.cpp b/libsysutils/src/SocketListener.cpp index 677c57dc1..611d5fe5f 100644 --- a/libsysutils/src/SocketListener.cpp +++ b/libsysutils/src/SocketListener.cpp @@ -225,6 +225,7 @@ void SocketListener::runListener() { } pthread_mutex_unlock(&mClientsLock); /* Destroy the client */ + close(c->getSocket()); delete c; } }