From 54ef57d0b8790ded0c6d36171e144c096c4d25b5 Mon Sep 17 00:00:00 2001 From: Josh Gao Date: Mon, 6 Feb 2017 21:08:38 -0800 Subject: [PATCH] debuggerd_handler: fix prctl return value check. Fixed this when I tested on internal, but failed to copy the fix over when submitting to AOSP. Bug: http://b/35070339 Test: `adb bugreport` on angler Change-Id: Ib84d212e5f890958cd21f5c018fbc6f368138d1e --- debuggerd/handler/debuggerd_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debuggerd/handler/debuggerd_handler.cpp b/debuggerd/handler/debuggerd_handler.cpp index 156534e19..38a7be35f 100644 --- a/debuggerd/handler/debuggerd_handler.cpp +++ b/debuggerd/handler/debuggerd_handler.cpp @@ -218,7 +218,7 @@ static int debuggerd_dispatch_pseudothread(void* arg) { close(pipefds[1]); // Set all of the ambient capability bits we can, so that crash_dump can ptrace us. - for (unsigned long i = 0; prctl(PR_CAPBSET_READ, i, 0, 0, 0); ++i) { + for (unsigned long i = 0; prctl(PR_CAPBSET_READ, i, 0, 0, 0) != -1; ++i) { prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, i, 0, 0); }