diff --git a/fastboot/fuzzy_fastboot/transport_sniffer.cpp b/fastboot/fuzzy_fastboot/transport_sniffer.cpp index b55ffd31a..0aef35005 100644 --- a/fastboot/fuzzy_fastboot/transport_sniffer.cpp +++ b/fastboot/fuzzy_fastboot/transport_sniffer.cpp @@ -90,7 +90,7 @@ std::string TransportSniffer::CreateTrace() { // and be printed as a string, or just a raw byte-buffer const auto msg = [&ret, no_print](const std::vector& buf) { ret += android::base::StringPrintf("(%lu bytes): ", buf.size()); - std::vector::iterator iter = buf.end(); + std::vector::const_iterator iter = buf.end(); const unsigned max_chars = 50; if (buf.size() > max_chars) { iter = buf.begin() + max_chars; diff --git a/init/keychords_test.cpp b/init/keychords_test.cpp index 5789bf58b..2b1d42831 100644 --- a/init/keychords_test.cpp +++ b/init/keychords_test.cpp @@ -168,16 +168,16 @@ const std::vector escape_chord = {KEY_ESC}; const std::vector triple1_chord = {KEY_BACKSPACE, KEY_VOLUMEDOWN, KEY_VOLUMEUP}; const std::vector triple2_chord = {KEY_VOLUMEDOWN, KEY_VOLUMEUP, KEY_BACK}; -const std::vector> empty_chords; -const std::vector> chords = { - escape_chord, - triple1_chord, - triple2_chord, +const std::vector> empty_chords; +const std::vector> chords = { + escape_chord, + triple1_chord, + triple2_chord, }; class TestFrame { public: - TestFrame(const std::vector>& chords, EventHandler* ev = nullptr); + TestFrame(const std::vector>& chords, EventHandler* ev = nullptr); void RelaxForMs(std::chrono::milliseconds wait = 1ms); @@ -194,16 +194,15 @@ class TestFrame { std::string Format() const; private: - static std::string Format(const std::vector>& chords); + static std::string Format(const std::vector>& chords); Epoll epoll_; Keychords keychords_; - std::vector> keycodes_; + std::vector> keycodes_; EventHandler* ev_; }; -TestFrame::TestFrame(const std::vector>& chords, EventHandler* ev) - : ev_(ev) { +TestFrame::TestFrame(const std::vector>& chords, EventHandler* ev) : ev_(ev) { if (!epoll_.Open().ok()) return; for (const auto& keycodes : chords) keychords_.Register(keycodes); keychords_.Start(&epoll_, [this](const std::vector& keycodes) { @@ -262,7 +261,7 @@ void TestFrame::WaitForChord(const std::vector& chord) { for (int retry = 1000; retry && !IsChord(chord); --retry) RelaxForMs(); } -std::string TestFrame::Format(const std::vector>& chords) { +std::string TestFrame::Format(const std::vector>& chords) { std::string ret("{"); if (!chords.empty()) { ret += android::base::Join(chords.front(), ' ');