From 516b632ff477616be473291ab5c939899c95ec38 Mon Sep 17 00:00:00 2001 From: Howard Ro Date: Mon, 18 May 2020 23:19:13 -0700 Subject: [PATCH] Remove statsd enable check when logging statsd should now be enabled on all devices and this check is unnnecessarily adding a check for each time there's a call into the socket, which is inefficient. Bug: 157082130 Test: make, statsd_test Change-Id: I0bb0ae0c93516c3a02cb971742c3eba602668a09 --- libstats/socket/stats_buffer_writer.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libstats/socket/stats_buffer_writer.c b/libstats/socket/stats_buffer_writer.c index 74acb20dc..549acdc8e 100644 --- a/libstats/socket/stats_buffer_writer.c +++ b/libstats/socket/stats_buffer_writer.c @@ -50,24 +50,16 @@ int stats_log_is_closed() { int write_buffer_to_statsd(void* buffer, size_t size, uint32_t atomId) { int ret = 1; -#ifdef __ANDROID__ - bool statsdEnabled = property_get_bool("ro.statsd.enable", true); -#else - bool statsdEnabled = false; -#endif + struct iovec vecs[2]; + vecs[0].iov_base = (void*)&kStatsEventTag; + vecs[0].iov_len = sizeof(kStatsEventTag); + vecs[1].iov_base = buffer; + vecs[1].iov_len = size; - if (statsdEnabled) { - struct iovec vecs[2]; - vecs[0].iov_base = (void*)&kStatsEventTag; - vecs[0].iov_len = sizeof(kStatsEventTag); - vecs[1].iov_base = buffer; - vecs[1].iov_len = size; + ret = __write_to_statsd(vecs, 2); - ret = __write_to_statsd(vecs, 2); - - if (ret < 0) { - note_log_drop(ret, atomId); - } + if (ret < 0) { + note_log_drop(ret, atomId); } return ret;