ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

metrics: 'Send' method crashes on NULL ErrorPtr

Browse source 
TEST=manually tested on panther_embedded
BUG=none

Change-Id: Iced380180918839d34a46e1cb2743a4cffdd5b4c
Reviewed-on: https://chromium-review.googlesource.com/220780
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Nathan Bullock <nathanbullock@google.com>
Tested-by: Nathan Bullock <nathanbullock@google.com>
This commit is contained in:
Nathan Bullock 2014-10-01 09:31:31 -04:00 • committed by chrome-internal-fetch
parent dfea2f8992
commit 52d9edb590
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
metrics/uploader/sender_http.cc
View file

@ -29,7 +29,9 @@ bool HttpSender::Send(const std::string& content,
chromeos::http::Transport::CreateDefault(),
&error);
if (!response || response->GetDataAsString() != "OK") {
DLOG(ERROR) << "Failed to send data: " << error->GetMessage();
if (error) {
DLOG(ERROR) << "Failed to send data: " << error->GetMessage();
}
return false;
}
return true;