From 4d6f4cc4fe51a06c2cf6bcb12f9e130c02824a7c Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Thu, 28 Feb 2019 06:34:25 -0800 Subject: [PATCH] libfs_avb: Pass const string by reference Minor performance improvement for ValidatePublicKeyBlob(). Test: TreeHugger Change-Id: I3498b529abedb8169d2488a2dc04cbd42cdb6f7d --- fs_mgr/libfs_avb/avb_util.cpp | 2 +- fs_mgr/libfs_avb/avb_util.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs_mgr/libfs_avb/avb_util.cpp b/fs_mgr/libfs_avb/avb_util.cpp index 7d899021a..f4e4d4ee8 100644 --- a/fs_mgr/libfs_avb/avb_util.cpp +++ b/fs_mgr/libfs_avb/avb_util.cpp @@ -326,7 +326,7 @@ bool ValidatePublicKeyBlob(const uint8_t* key, size_t length, return false; } -bool ValidatePublicKeyBlob(const std::string key_blob_to_validate, +bool ValidatePublicKeyBlob(const std::string& key_blob_to_validate, const std::vector& allowed_key_paths) { std::string allowed_key_blob; if (key_blob_to_validate.empty()) { diff --git a/fs_mgr/libfs_avb/avb_util.h b/fs_mgr/libfs_avb/avb_util.h index 986a69a92..09c786a52 100644 --- a/fs_mgr/libfs_avb/avb_util.h +++ b/fs_mgr/libfs_avb/avb_util.h @@ -80,7 +80,7 @@ VBMetaVerifyResult VerifyVBMetaSignature(const VBMetaData& vbmeta, bool ValidatePublicKeyBlob(const uint8_t* key, size_t length, const std::string& expected_key_blob); -bool ValidatePublicKeyBlob(const std::string key_blob_to_validate, +bool ValidatePublicKeyBlob(const std::string& key_blob_to_validate, const std::vector& expected_key_paths); // Detects if whether a partition contains a rollback image.