ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Fix off by one error."

Browse source
This commit is contained in:
Treehugger Robot 2018-10-24 00:52:15 +00:00 • committed by Gerrit Code Review
commit 551efd11f7
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libunwindstack/RegsInfo.h
View file

@ -41,7 +41,7 @@ struct RegsInfo {
}
inline AddressType* Save(uint32_t reg) {
if (reg > MAX_REGISTERS) {
if (reg >= MAX_REGISTERS) {
// This should never happen since all currently supported
// architectures have < 64 total registers.
abort();

7
libunwindstack/tests/RegsInfoTest.cpp
View file

@ -82,4 +82,11 @@ TEST(RegsInfoTest, all) {
}
}
TEST(RegsInfoTest, invalid_register) {
RegsImplFake<uint64_t> regs(64);
RegsInfo<uint64_t> info(&regs);
EXPECT_DEATH(info.Save(RegsInfo<uint64_t>::MAX_REGISTERS), "");
}
} // namespace unwindstack