From dd34ca45ea80c519a579578562e73d5e7f86703b Mon Sep 17 00:00:00 2001 From: Keun-young Park Date: Fri, 11 Nov 2016 18:06:31 -0800 Subject: [PATCH] fix swapped min / max in priority parsing - This error led into not handling highest priority, which made zygote's priority boost no-op bug: 32718256 Test: check init log during bootup Change-Id: I959eb94912a9c1d95bfdb98ee675fdd12cf85699 --- init/service.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init/service.cpp b/init/service.cpp index 9fa11b85b..f093dd9c0 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -357,8 +357,8 @@ bool Service::ParseGroup(const std::vector& args, std::string* err) bool Service::ParsePriority(const std::vector& args, std::string* err) { priority_ = 0; if (!ParseInt(args[1], &priority_, - static_cast(ANDROID_PRIORITY_LOWEST), - static_cast(ANDROID_PRIORITY_HIGHEST))) { + static_cast(ANDROID_PRIORITY_HIGHEST), // highest is negative + static_cast(ANDROID_PRIORITY_LOWEST))) { *err = StringPrintf("process priority value must be range %d - %d", ANDROID_PRIORITY_HIGHEST, ANDROID_PRIORITY_LOWEST); return false;