From a56a729c1402d1d65c53171577861cef5b0c41c4 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 26 Oct 2018 10:34:53 -0700 Subject: [PATCH] More Mac build fixes. The libziparchive public headers that refer to `off64_t` also need the Mac workaround. In fastboot, there's a stray `lseek64` but since it's only for offset 0, any kind of seek is fine. Bug: N/A Test: builds Change-Id: I68b4f95202623ebf07ffe6c3e0e21437e7922c5b --- fastboot/fastboot.cpp | 2 +- libziparchive/Android.bp | 1 + libziparchive/include/ziparchive/zip_archive.h | 2 ++ .../include/ziparchive/zip_archive_stream_entry.h | 9 ++++----- libziparchive/include/ziparchive/zip_writer.h | 1 + 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/fastboot/fastboot.cpp b/fastboot/fastboot.cpp index 81350fdb3..24f74f05b 100644 --- a/fastboot/fastboot.cpp +++ b/fastboot/fastboot.cpp @@ -852,7 +852,7 @@ static bool load_buf_fd(int fd, struct fastboot_buffer* buf) { buf->image_size = sz; } - lseek64(fd, 0, SEEK_SET); + lseek(fd, 0, SEEK_SET); int64_t limit = get_sparse_limit(sz); if (limit) { sparse_file** s = load_sparse_files(fd, limit); diff --git a/libziparchive/Android.bp b/libziparchive/Android.bp index 608afb7fd..2095189ec 100644 --- a/libziparchive/Android.bp +++ b/libziparchive/Android.bp @@ -73,6 +73,7 @@ cc_library { enabled: true, }, double_loadable: true, + export_shared_lib_headers: ["libbase"], defaults: [ "libziparchive_defaults", diff --git a/libziparchive/include/ziparchive/zip_archive.h b/libziparchive/include/ziparchive/zip_archive.h index 3952532b0..ab38dfd2c 100644 --- a/libziparchive/include/ziparchive/zip_archive.h +++ b/libziparchive/include/ziparchive/zip_archive.h @@ -25,6 +25,8 @@ #include #include +#include "android-base/off64_t.h" + /* Zip compression methods we support */ enum { kCompressStored = 0, // no compression diff --git a/libziparchive/include/ziparchive/zip_archive_stream_entry.h b/libziparchive/include/ziparchive/zip_archive_stream_entry.h index b4766f86a..8c6ca795a 100644 --- a/libziparchive/include/ziparchive/zip_archive_stream_entry.h +++ b/libziparchive/include/ziparchive/zip_archive_stream_entry.h @@ -15,12 +15,13 @@ */ // Read-only stream access to Zip archives entries. -#ifndef LIBZIPARCHIVE_ZIPARCHIVESTREAMENTRY_H_ -#define LIBZIPARCHIVE_ZIPARCHIVESTREAMENTRY_H_ +#pragma once + +#include #include -#include +#include "android-base/off64_t.h" class ZipArchiveStreamEntry { public: @@ -43,5 +44,3 @@ class ZipArchiveStreamEntry { off64_t offset_ = 0; uint32_t crc32_ = 0u; }; - -#endif // LIBZIPARCHIVE_ZIPARCHIVESTREAMENTRY_H_ diff --git a/libziparchive/include/ziparchive/zip_writer.h b/libziparchive/include/ziparchive/zip_writer.h index 6e4ca62cf..f6c842723 100644 --- a/libziparchive/include/ziparchive/zip_writer.h +++ b/libziparchive/include/ziparchive/zip_writer.h @@ -24,6 +24,7 @@ #include #include "android-base/macros.h" +#include "android-base/off64_t.h" struct z_stream_s; typedef struct z_stream_s z_stream;