ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "init: warn slow action"

Browse source
This commit is contained in:
Treehugger Robot 2016-11-10 00:53:03 +00:00 • committed by Gerrit Code Review
commit 5782f72711
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
init/action.cpp
View file

@ -118,14 +118,16 @@ void Action::ExecuteCommand(const Command& command) const {
Timer t; Timer t;
int result = command.InvokeFunc(); int result = command.InvokeFunc();
// TODO: this should probably be changed to "if (failed || took a long time)"... double duration_ms = t.duration() * 1000;
if (android::base::GetMinimumLogSeverity() <= android::base::DEBUG) { // Any action longer than 50ms will be warned to user as slow operation
if (duration_ms > 50.0 ||
android::base::GetMinimumLogSeverity() <= android::base::DEBUG) {
std::string trigger_name = BuildTriggersString(); std::string trigger_name = BuildTriggersString();
std::string cmd_str = command.BuildCommandString(); std::string cmd_str = command.BuildCommandString();
std::string source = command.BuildSourceString(); std::string source = command.BuildSourceString();
LOG(INFO) << "Command '" << cmd_str << "' action=" << trigger_name << source LOG(INFO) << "Command '" << cmd_str << "' action=" << trigger_name << source
<< " returned " << result << " took " << t.duration() << "s"; << " returned " << result << " took " << duration_ms << "ms.";
} }
} }