ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "adbd: Fix check against valid payload size"

Browse source
This commit is contained in:
Josh Gao 2020-09-18 23:01:18 +00:00 • committed by Gerrit Code Review
commit 596f3b5384
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
adb/daemon/usb.cpp
View file

@ -584,12 +584,11 @@ struct UsbFfsConnection : public Connection {
incoming_header_ = msg; incoming_header_ = msg;
} else { } else {
size_t bytes_left = incoming_header_->data_length - incoming_payload_.size(); size_t bytes_left = incoming_header_->data_length - incoming_payload_.size();
Block payload = std::move(block->payload);
if (block->payload.size() > bytes_left) { if (block->payload.size() > bytes_left) {
HandleError("received too many bytes while waiting for payload"); HandleError("received too many bytes while waiting for payload");
return false; return false;
} }
incoming_payload_.append(std::move(payload)); incoming_payload_.append(std::move(block->payload));
} }
if (incoming_header_->data_length == incoming_payload_.size()) { if (incoming_header_->data_length == incoming_payload_.size()) {