From 5d13645bfe47568845c700149c8a2165a1813b3a Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 9 Mar 2020 14:22:16 -0700 Subject: [PATCH] Fix bugprone-string-integer-assignment warnings * mdns.cpp:153:20: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility [bugprone-string-integer-assignment] Test: WITH_TIDY=1 make Change-Id: Id9a790ac31722c6ee8886703939977b913ce95fe --- adb/daemon/mdns.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/adb/daemon/mdns.cpp b/adb/daemon/mdns.cpp index fa692c039..c1e766eba 100644 --- a/adb/daemon/mdns.cpp +++ b/adb/daemon/mdns.cpp @@ -150,11 +150,11 @@ static std::string RandomAlphaNumString(size_t len) { for (size_t i = 0; i < len; ++i) { uint8_t val = dist(mt); if (val < 10) { - ret += '0' + val; + ret += static_cast('0' + val); } else if (val < 36) { - ret += 'A' + (val - 10); + ret += static_cast('A' + (val - 10)); } else { - ret += 'a' + (val - 36); + ret += static_cast('a' + (val - 36)); } } return ret;