From 5dd72ac4960f089d9750d388c8bb0e9a7170426e Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Tue, 30 Jan 2024 10:17:37 +0900 Subject: [PATCH] Drop CtsInitTestCases from cts The test is not eligible for CTS. Reasons: 1. The init behavior does not directly affect app compat. App interact with init only for the property service and that part is covered by the Bionic test already. 2. This test doesn't run against the init binary installed on the device. libinit where most of the init functionalities are implemented is statically linked to this test binary. In other words, this test is closer to a unit test for init. 3. This test is not compatible with Trunk stable where test and DUT are built in different branches. The test depends on several (private) libraries like libbase and libutils. Since the interfaces of the libraries may have changed in the main branch, the test binary built from the old test-dev branch may break. This change does not remove the test. The test will still run as a unit test during pre/post submit. I didn't drop the `Cts` prefix from the name, because that requires broader changes. Bug: 320800872 Test: N/A Change-Id: I1402c08b79b57ad6daa7948fe37f14fbbe36f1d6 (cherry picked from commit 75070b37e280dd76c0f00d5bf2a8eb96053b1483) --- init/Android.bp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Android.bp b/init/Android.bp index 7b529033a..cf4ccc4be 100644 --- a/init/Android.bp +++ b/init/Android.bp @@ -450,6 +450,7 @@ phony { // ------------------------------------------------------------------------------ cc_test { + // Note: This is NOT a CTS test. See b/320800872 name: "CtsInitTestCases", defaults: ["init_defaults"], require_root: true, @@ -482,7 +483,6 @@ cc_test { ], test_suites: [ - "cts", "device-tests", ], }