ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

adb: print better error message when there are insufficient permissions for a device.

Browse source 
Now, a command like "adb shell" will print "insufficient permissions for device"
instead of "device not found" if adb does not have permissions to communicate with the device.

Signed-off-by: Mike Lockwood <lockwood@android.com>
This commit is contained in:
Mike Lockwood 2009-08-08 13:53:16 -04:00
parent a8be72f653
commit 668cc77101
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
adb/transport.c
View file

@ -720,7 +720,11 @@ retry:
adb_mutex_lock(&transport_lock);
for (t = transport_list.next; t != &transport_list; t = t->next) {
if (t->connection_state == CS_NOPERM) continue;
if (t->connection_state == CS_NOPERM) {
if (error_out)
*error_out = "insufficient permissions for device";
continue;
}
/* check for matching serial number */
if (serial) {
@ -768,12 +772,6 @@ retry:
*error_out = "device offline";
result = NULL;
}
if (result && result->connection_state == CS_NOPERM) {
if (error_out)
*error_out = "no permissions for device";
result = NULL;
}
/* check for required connection state */
if (result && state != CS_ANY && result->connection_state != state) {
if (error_out)