From 55fd316ea798f2c77ad80def9f9b50d59391f1c2 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Wed, 1 Apr 2015 22:31:40 -0700 Subject: [PATCH] Give SocketListener some FD_CLOEXEC. Sockets love FD_CLOEXEC. Bug: 19993667 Change-Id: I0d72a27e0f46b79843bb91ed48ebaf1c89484fd2 --- libsysutils/src/SocketListener.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libsysutils/src/SocketListener.cpp b/libsysutils/src/SocketListener.cpp index 527a6a0a3..3011ed7a8 100644 --- a/libsysutils/src/SocketListener.cpp +++ b/libsysutils/src/SocketListener.cpp @@ -86,6 +86,7 @@ int SocketListener::startListener(int backlog) { return -1; } SLOGV("got mSock = %d for %s", mSock, mSocketName); + fcntl(mSock, F_SETFD, FD_CLOEXEC); } if (mListen && listen(mSock, backlog) < 0) { @@ -212,6 +213,7 @@ void SocketListener::runListener() { sleep(1); continue; } + fcntl(c, F_SETFD, FD_CLOEXEC); pthread_mutex_lock(&mClientsLock); mClients->push_back(new SocketClient(c, true, mUseCmdNum)); pthread_mutex_unlock(&mClientsLock);