From 6d1b644930d2c89ce967bcecc7fa4af0290e8fcd Mon Sep 17 00:00:00 2001 From: Tomasz Wasilczyk Date: Mon, 14 Aug 2023 15:47:29 +0000 Subject: [PATCH] Drop String::empty() This method causes confuction and bugs by having the same name, but different meaning versus std::string::empty(). Bug: 295394788 Test: make checkbuild Change-Id: I15aadc023b20559930e4ec79f43f7032e8cd90d0 --- libutils/include/utils/String8.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/libutils/include/utils/String8.h b/libutils/include/utils/String8.h index e58f1a5d1..ace0243f3 100644 --- a/libutils/include/utils/String8.h +++ b/libutils/include/utils/String8.h @@ -52,8 +52,6 @@ public: explicit String8(const char32_t* o, size_t numChars); ~String8(); - static inline const String8 empty(); - static String8 format(const char* fmt, ...) __attribute__((format (printf, 1, 2))); static String8 formatV(const char* fmt, va_list args); @@ -240,10 +238,6 @@ inline int strictly_order_type(const String8& lhs, const String8& rhs) return compare_type(lhs, rhs) < 0; } -inline const String8 String8::empty() { - return String8(); -} - inline const char* String8::c_str() const { return mString;