ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Fix static analyzer warnings"

Browse source
This commit is contained in:
Treehugger Robot 2017-09-13 08:34:19 +00:00 • committed by Gerrit Code Review
commit 7176951b9b
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
libmemunreachable/tests/DisableMalloc_test.cpp
View file

@ -73,15 +73,18 @@ TEST_F(DisableMallocTest, deadlock_allocate) {
TEST_F(DisableMallocTest, deadlock_new) {
ASSERT_DEATH(
{
char* ptr = new (char);
// C++ allows `new Foo` to be replaced with a stack allocation or merged
// with future `new Foo` expressions, provided certain conditions are
// met [expr.new/10]. None of this applies to `operator new(size_t)`.
void* ptr = ::operator new(1);
ASSERT_NE(ptr, nullptr);
delete (ptr);
::operator delete(ptr);
{
alarm(100ms);
ScopedDisableMalloc disable_malloc;
char* ptr = new (std::nothrow)(char);
void* ptr = ::operator new(1);
ASSERT_NE(ptr, nullptr);
delete (ptr);
::operator delete(ptr);
}
},
"");
@ -90,14 +93,12 @@ TEST_F(DisableMallocTest, deadlock_new) {
TEST_F(DisableMallocTest, deadlock_delete) {
ASSERT_DEATH(
{
char* ptr = new (char);
void* ptr = ::operator new(1);
ASSERT_NE(ptr, nullptr);
{
alarm(250ms);
ScopedDisableMalloc disable_malloc;
delete (ptr);
// Force ptr usage or this code gets optimized away by the arm64 compiler.
ASSERT_NE(ptr, nullptr);
::operator delete(ptr);
}
},
"");