ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make mkdirAndChown do what it claims to do

Browse source 
Currently, mkdirAndChown takes parameters for mode, uid and gid, but
ignores them and hardcodes 0750, AID_SYSTEM, AID_SYSTEM instead.
This doesn't matter much because so far its only invocation passes
exactly those values as parameters -- but clang complains about unused
parameters.

Might as well make the function do what it claims to do.

Change-Id: I5a8056be3278a0c5d0a576dbc061288aa0956a35
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
This commit is contained in:
Bernhard Rosenkränzer 2014-11-17 20:46:00 +01:00
parent 3ef0460e86
commit 758aeb7dad
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libprocessgroup/processgroup.cpp
View file

@ -279,12 +279,12 @@ static int mkdirAndChown(const char *path, mode_t mode, uid_t uid, gid_t gid)
{
int ret;
ret = mkdir(path, 0750);
ret = mkdir(path, mode);
if (ret < 0 && errno != EEXIST) {
return -errno;
}
ret = chown(path, AID_SYSTEM, AID_SYSTEM);
ret = chown(path, uid, gid);
if (ret < 0) {
ret = -errno;
rmdir(path);