diff --git a/libcutils/Android.mk b/libcutils/Android.mk index 79344e6d5..6fb8c22c6 100644 --- a/libcutils/Android.mk +++ b/libcutils/Android.mk @@ -73,7 +73,7 @@ LOCAL_MODULE := libcutils LOCAL_SRC_FILES := $(commonSources) $(commonHostSources) dlmalloc_stubs.c LOCAL_STATIC_LIBRARIES := liblog ifneq ($(HOST_OS),windows) -LOCAL_CFLAGS += -Werror +LOCAL_CFLAGS += -Werror -Wall -Wextra endif LOCAL_MULTILIB := both include $(BUILD_HOST_STATIC_LIBRARY) @@ -83,7 +83,7 @@ LOCAL_MODULE := libcutils LOCAL_SRC_FILES := $(commonSources) $(commonHostSources) dlmalloc_stubs.c LOCAL_SHARED_LIBRARIES := liblog ifneq ($(HOST_OS),windows) -LOCAL_CFLAGS += -Werror +LOCAL_CFLAGS += -Werror -Wall -Wextra endif LOCAL_MULTILIB := both include $(BUILD_HOST_SHARED_LIBRARY) @@ -125,7 +125,7 @@ LOCAL_STATIC_LIBRARIES := liblog ifneq ($(ENABLE_CPUSETS),) LOCAL_CFLAGS += -DUSE_CPUSETS endif -LOCAL_CFLAGS += -Werror -std=gnu90 +LOCAL_CFLAGS += -Werror -Wall -Wextra -std=gnu90 include $(BUILD_STATIC_LIBRARY) include $(CLEAR_VARS) @@ -137,7 +137,7 @@ LOCAL_SHARED_LIBRARIES := liblog ifneq ($(ENABLE_CPUSETS),) LOCAL_CFLAGS += -DUSE_CPUSETS endif -LOCAL_CFLAGS += -Werror +LOCAL_CFLAGS += -Werror -Wall -Wextra LOCAL_C_INCLUDES := $(libcutils_c_includes) include $(BUILD_SHARED_LIBRARY) diff --git a/libcutils/fs_config.c b/libcutils/fs_config.c index 08df9de99..171d0f7f2 100644 --- a/libcutils/fs_config.c +++ b/libcutils/fs_config.c @@ -167,8 +167,7 @@ static int fs_config_open(int dir, const char *target_out_path) if (target_out_path[target_out_path_len] == '/') { skip_len++; } - asprintf(&name, "%s%s", target_out_path, (dir ? conf_dir : conf_file) + skip_len); - if (name) { + if (asprintf(&name, "%s%s", target_out_path, (dir ? conf_dir : conf_file) + skip_len) != -1) { fd = TEMP_FAILURE_RETRY(open(name, O_RDONLY | O_BINARY)); free(name); }