From d06cb94d254e294a345af2712c8c6627bfa543a4 Mon Sep 17 00:00:00 2001 From: Nicolas Geoffray Date: Wed, 16 Jan 2019 20:20:27 +0000 Subject: [PATCH] libnativeloader: remove stubs for now. Seems to break VMDebug test. Also add missed strdup in returned error message. bug: 122957265 Test: VMDebug Change-Id: I64727d707f20c0e6afcb5455edf20c99011a81dc --- libnativeloader/Android.bp | 9 --------- libnativeloader/native_loader.cpp | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/libnativeloader/Android.bp b/libnativeloader/Android.bp index 8903b72c7..2802d3611 100644 --- a/libnativeloader/Android.bp +++ b/libnativeloader/Android.bp @@ -23,15 +23,6 @@ cc_library { "llndk.libraries.txt", "vndksp.libraries.txt", ], - target: { - android: { - version_script: "libnativeloader.map.txt", - }, - }, - stubs: { - symbol_file: "libnativeloader.map.txt", - versions: ["1"], - }, } cc_library_headers { diff --git a/libnativeloader/native_loader.cpp b/libnativeloader/native_loader.cpp index f231afa5b..af7df727a 100644 --- a/libnativeloader/native_loader.cpp +++ b/libnativeloader/native_loader.cpp @@ -632,7 +632,7 @@ void* OpenNativeLibrary(JNIEnv* env, int32_t target_sdk_version, const char* pat *needs_native_bridge = false; void* handle = dlopen(path, RTLD_NOW); if (handle == nullptr) { - *error_msg = dlerror(); + *error_msg = strdup(dlerror()); } return handle; }