From 9ee1f5f034e44dd20b3cb229db601eeb1098a3d6 Mon Sep 17 00:00:00 2001 From: Ken Mixter Date: Tue, 25 Oct 2011 02:15:05 +0000 Subject: [PATCH] crash-reporter: always write kernel crashes for dev builds Added check for devloper build. Always write kernel crash files when running devloper builds. BUG=None TEST=run "echo bug > /proc/breakme" and ensure the kcrash files get created under /var/spool/crash Change-Id: Iced35df9db1f997c41138f082ee50a3506a88eb2 Reviewed-on: https://gerrit.chromium.org/gerrit/10615 Reviewed-by: Sameer Nanda Tested-by: Sameer Nanda --- crash_reporter/kernel_collector.cc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/crash_reporter/kernel_collector.cc b/crash_reporter/kernel_collector.cc index de4f92db7..bdd1dd203 100644 --- a/crash_reporter/kernel_collector.cc +++ b/crash_reporter/kernel_collector.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium OS Authors. All rights reserved. +// Copyright (c) 2011 The Chromium OS Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -448,11 +448,18 @@ bool KernelCollector::Collect() { signature = kDefaultKernelStackSignature; } - bool feedback = is_feedback_allowed_function_(); + std::string reason = "handling"; + bool feedback = true; + if (IsDeveloperImage()) { + reason = "developer build - always dumping"; + feedback = true; + } else if (!is_feedback_allowed_function_()) { + reason = "ignoring - no consent"; + feedback = false; + } LOG(INFO) << "Received prior crash notification from " - << "kernel (signature " << signature << ") (" - << (feedback ? "handling" : "ignoring - no consent") << ")"; + << "kernel (signature " << signature << ") (" << reason << ")"; if (feedback) { count_crash_function_();