ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

healthd: notify listeners using local copy of list, drop lock

Browse source 
am: fd68370074

Change-Id: I8b8c8bb2b2eede878bb44afcaa08f73142a10d64
This commit is contained in:
Todd Poynor 2017-06-27 21:52:29 +00:00 • committed by android-build-merger
commit a1f4cddfea
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
healthd/BatteryPropertiesRegistrar.cpp
View file

@ -36,9 +36,19 @@ void BatteryPropertiesRegistrar::publish(
} }
void BatteryPropertiesRegistrar::notifyListeners(const struct BatteryProperties& props) { void BatteryPropertiesRegistrar::notifyListeners(const struct BatteryProperties& props) {
Mutex::Autolock _l(mRegistrationLock); Vector<sp<IBatteryPropertiesListener> > listenersCopy;
for (size_t i = 0; i < mListeners.size(); i++) {
mListeners[i]->batteryPropertiesChanged(props); // Binder currently may service an incoming oneway transaction whenever an
// outbound oneway call is made (if there is already a pending incoming
// oneway call waiting). This is considered a bug and may change in the
// future. For now, avoid recursive mutex lock while making outbound
// calls by making a local copy of the current list of listeners.
{
Mutex::Autolock _l(mRegistrationLock);
listenersCopy = mListeners;
}
for (size_t i = 0; i < listenersCopy.size(); i++) {
listenersCopy[i]->batteryPropertiesChanged(props);
} }
} }