From 975491be09d1f3be11804d1fda53514d32c354be Mon Sep 17 00:00:00 2001 From: Wenhao Wang Date: Fri, 2 Oct 2020 12:32:30 -0700 Subject: [PATCH] rpmb_dev: Fix RPMB_REQ_DATA_READ command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add ".check_key_programmed = true." for RPMB_REQ_DATA_READ such that we can check whether the rpmb key has been programmed before executing RPMB_REQ_DATA_READ command. "JEDEC STANDARD Universal Flash Storage (UFS) Version 3.0" specifies that data access before the key has been programmed should return “Authentication Key not yet programmed” (0007h).. Bug: 152901318 Test: Trusty storage tests Change-Id: I4759fbce5f37234090a22a1d9dc3b38072f6ecaf --- trusty/utils/rpmb_dev/rpmb_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trusty/utils/rpmb_dev/rpmb_dev.c b/trusty/utils/rpmb_dev/rpmb_dev.c index 5de1efa47..202562114 100644 --- a/trusty/utils/rpmb_dev/rpmb_dev.c +++ b/trusty/utils/rpmb_dev/rpmb_dev.c @@ -283,6 +283,7 @@ static struct rpmb_dev_cmd rpmb_dev_cmd_table[] = { { .func = rpmb_dev_data_read, .resp = RPMB_RESP_DATA_READ, + .check_key_programmed = true, .check_addr = true, .multi_packet_res = true, .res_mac = true,