ACPR/android_system_core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "adb: avoid sign extension of shell return code."

Browse source 
am: b5ac15a936

Change-Id: Ib4018e339435eb8a4c79070c1096f076996d0386
This commit is contained in:
Josh Gao 2019-03-15 21:14:34 -07:00 • committed by android-build-merger
commit a6397564b6
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
adb/client/commandline.cpp
View file

@ -295,7 +295,10 @@ int read_and_dump(int fd, bool use_shell_protocol = false,
callback->OnStderr(buffer_ptr, length);
break;
case ShellProtocol::kIdExit:
exit_code = protocol->data()[0];
// data() returns a char* which doesn't have defined signedness.
// Cast to uint8_t to prevent 255 from being sign extended to INT_MIN,
// which doesn't get truncated on Windows.
exit_code = static_cast<uint8_t>(protocol->data()[0]);
continue;
default:
continue;