diff --git a/fs_mgr/README.overlayfs.md b/fs_mgr/README.overlayfs.md index 2aac2601a..f89e598c6 100644 --- a/fs_mgr/README.overlayfs.md +++ b/fs_mgr/README.overlayfs.md @@ -94,7 +94,7 @@ Caveats and thus free dynamic partition space. - Kernel must have CONFIG_OVERLAY_FS=y and will need to be patched with "*overlayfs: override_creds=off option bypass creator_cred*" - if kernel is higher than 4.6. + if kernel is 4.4 or higher. The patch is available on the upstream mailing list and the latest as of Feb 8 2019 is https://lore.kernel.org/patchwork/patch/1009299/. This patch adds an override_creds _mount_ option to overlayfs that diff --git a/fs_mgr/fs_mgr_overlayfs.cpp b/fs_mgr/fs_mgr_overlayfs.cpp index 3d5062c4a..40da36d87 100644 --- a/fs_mgr/fs_mgr_overlayfs.cpp +++ b/fs_mgr/fs_mgr_overlayfs.cpp @@ -1031,7 +1031,7 @@ OverlayfsValidResult fs_mgr_overlayfs_valid() { if (major > 4) { return OverlayfsValidResult::kNotSupported; } - if (minor > 6) { + if (minor > 3) { return OverlayfsValidResult::kNotSupported; } return OverlayfsValidResult::kOk; diff --git a/fs_mgr/tests/adb-remount-test.sh b/fs_mgr/tests/adb-remount-test.sh index 8a1b6d6ea..fd53ed4b4 100755 --- a/fs_mgr/tests/adb-remount-test.sh +++ b/fs_mgr/tests/adb-remount-test.sh @@ -577,20 +577,17 @@ adb_sh ls -d /sys/module/overlay /dev/null 2>/dev/null || ) || overlayfs_supported=false if ${overlayfs_supported}; then - case `adb_sh uname -r /dev/null && - echo "${GREEN}[ OK ]${NORMAL} overlay module supports override_creds" >&2 || - ( - echo "${ORANGE}[ WARNING ]${NORMAL} overlay module does not support override_creds" >&2 && - false - ) || + adb_su ls /sys/module/overlay/parameters/override_creds /dev/null && + echo "${GREEN}[ OK ]${NORMAL} overlay module supports override_creds" >&2 || + case `adb_sh uname -r &2 && overlayfs_supported=false - ;; - *) - echo "${GREEN}[ OK ]${NORMAL} overlay module uses callers creds" >&2 - ;; - esac + ;; + *) + echo "${GREEN}[ OK ]${NORMAL} overlay module uses caller's creds" >&2 + ;; + esac fi adb_root ||