From 726e8f7a8f3603f952055e440e21cc69c7340b36 Mon Sep 17 00:00:00 2001 From: Stephen Smalley Date: Wed, 9 Oct 2013 16:02:09 -0400 Subject: [PATCH] Add a restorecon_recursive built-in command to init. Functionally equivalent to the restorecon -R toolbox command. A use case is given by: I48eaa2b9901ac8c978192c14493ba1058a089423 Also, fix error handling and documentation for restorecon command. Change-Id: Ia7fbcc82645baf52c6bff0490d3492f458881cbb Signed-off-by: Stephen Smalley --- init/builtins.c | 16 ++++++++++++++-- init/init_parser.c | 1 + init/keywords.h | 2 ++ init/readme.txt | 8 +++++++- 4 files changed, 24 insertions(+), 3 deletions(-) diff --git a/init/builtins.c b/init/builtins.c index 576f0d92a..33fc6c6be 100644 --- a/init/builtins.c +++ b/init/builtins.c @@ -747,12 +747,24 @@ int do_chmod(int nargs, char **args) { int do_restorecon(int nargs, char **args) { int i; + int ret = 0; for (i = 1; i < nargs; i++) { if (restorecon(args[i]) < 0) - return -errno; + ret = -errno; } - return 0; + return ret; +} + +int do_restorecon_recursive(int nargs, char **args) { + int i; + int ret = 0; + + for (i = 1; i < nargs; i++) { + if (restorecon_recursive(args[i]) < 0) + ret = -errno; + } + return ret; } int do_setsebool(int nargs, char **args) { diff --git a/init/init_parser.c b/init/init_parser.c index 2c2c91c0c..38582f569 100644 --- a/init/init_parser.c +++ b/init/init_parser.c @@ -133,6 +133,7 @@ int lookup_keyword(const char *s) case 'r': if (!strcmp(s, "estart")) return K_restart; if (!strcmp(s, "estorecon")) return K_restorecon; + if (!strcmp(s, "estorecon_recursive")) return K_restorecon_recursive; if (!strcmp(s, "mdir")) return K_rmdir; if (!strcmp(s, "m")) return K_rm; break; diff --git a/init/keywords.h b/init/keywords.h index f188db5d7..414db0852 100644 --- a/init/keywords.h +++ b/init/keywords.h @@ -16,6 +16,7 @@ int do_mount_all(int nargs, char **args); int do_mount(int nargs, char **args); int do_restart(int nargs, char **args); int do_restorecon(int nargs, char **args); +int do_restorecon_recursive(int nargs, char **args); int do_rm(int nargs, char **args); int do_rmdir(int nargs, char **args); int do_setcon(int nargs, char **args); @@ -68,6 +69,7 @@ enum { KEYWORD(onrestart, OPTION, 0, 0) KEYWORD(restart, COMMAND, 1, do_restart) KEYWORD(restorecon, COMMAND, 1, do_restorecon) + KEYWORD(restorecon_recursive, COMMAND, 1, do_restorecon_recursive) KEYWORD(rm, COMMAND, 1, do_rm) KEYWORD(rmdir, COMMAND, 1, do_rmdir) KEYWORD(seclabel, OPTION, 0, 0) diff --git a/init/readme.txt b/init/readme.txt index 1e8c3920d..42a09cb82 100644 --- a/init/readme.txt +++ b/init/readme.txt @@ -192,12 +192,18 @@ mount [ ]* device by name. s include "ro", "rw", "remount", "noatime", ... -restorecon +restorecon [ ]* Restore the file named by to the security context specified in the file_contexts configuration. Not required for directories created by the init.rc as these are automatically labeled correctly by init. +restorecon_recursive [ ]* + Recursively restore the directory tree named by to the + security contexts specified in the file_contexts configuration. + Do NOT use this with paths leading to shell-writable or app-writable + directories, e.g. /data/local/tmp, /data/data or any prefix thereof. + setcon Set the current process security context to the specified string. This is typically only used from early-init to set the init context