From ae33866aeaa2071fd736abc2a7dc27c3fe9e8e51 Mon Sep 17 00:00:00 2001 From: Sergiu Iordache Date: Fri, 5 Aug 2011 15:32:15 -0700 Subject: [PATCH] crash-reporter: Activate updated BadDirectory test Activated the BadDirectory test which was breaking the build. BUG=chromium-os:18622 TEST=Ran the unit tests locally and it succeded. Change-Id: I439d9fb40ec37261ef839c82817d6bc67e683c7d Signed-off-by: Sergiu Iordache Reviewed-on: http://gerrit.chromium.org/gerrit/5433 Reviewed-by: Ken Mixter Tested-by: Michael Krebs --- crash_reporter/kernel_collector_test.cc | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/crash_reporter/kernel_collector_test.cc b/crash_reporter/kernel_collector_test.cc index 35bb0ec33..87c251b24 100644 --- a/crash_reporter/kernel_collector_test.cc +++ b/crash_reporter/kernel_collector_test.cc @@ -230,15 +230,14 @@ TEST_F(KernelCollectorTest, CollectNoCrash) { ASSERT_EQ(0, s_crashes); } -// Disabled for crosbug.com/18622 -//TEST_F(KernelCollectorTest, CollectBadDirectory) { -// collector_.SetParameters(17, 0, 17); -// WriteStringToFile(test_kcrash_, "====1.1\nsomething"); -// ASSERT_TRUE(collector_.Collect()); -// ASSERT_TRUE(FindLog( -// "Unable to create appropriate crash directory")); -// ASSERT_EQ(1, s_crashes); -//} +TEST_F(KernelCollectorTest, CollectBadDirectory) { + collector_.SetParameters(17, 0, 17); + WriteStringToFile(test_kcrash_, "====1.1\nsomething"); + ASSERT_TRUE(collector_.Collect()); + ASSERT_TRUE(FindLog( + "Unable to create appropriate crash directory")); + ASSERT_EQ(1, s_crashes); +} void KernelCollectorTest::SetUpSuccessfulCollect() { collector_.ForceCrashDirectory(kTestCrashDirectory);