From b02f94490dc84877c210eb1b46a9b57d96fc45b2 Mon Sep 17 00:00:00 2001 From: "T.J. Mercier" Date: Fri, 6 Oct 2023 23:11:09 +0000 Subject: [PATCH] libprocessgroup: Don't sleep after last cgroup removal attempt Currently we sleep for 5ms before decrementing retries for the last time. This is a waste of time, so bail out of the loop if the last rmdir attempt fails. Change-Id: Ia20840d27592b4eb3d9762647b19c111ff94209f --- libprocessgroup/processgroup.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libprocessgroup/processgroup.cpp b/libprocessgroup/processgroup.cpp index 450643912..cc2565fad 100644 --- a/libprocessgroup/processgroup.cpp +++ b/libprocessgroup/processgroup.cpp @@ -219,7 +219,7 @@ static int RemoveProcessGroup(const char* cgroup, uid_t uid, int pid, unsigned i while (retries--) { ret = rmdir(uid_pid_path.c_str()); - if (!ret || errno != EBUSY) break; + if (!ret || errno != EBUSY || !retries) break; std::this_thread::sleep_for(5ms); }