From b1ac89bb1f53cba2b9018a47826167a2375a246b Mon Sep 17 00:00:00 2001 From: Michael Krebs Date: Mon, 26 Sep 2011 20:04:04 -0700 Subject: [PATCH] Revert "crash-reporter: Activate updated BadDirectory test" This reverts commit 4a029228b93edcd9cf79c2578acd27eb56be5bce Although this passes in my local checkout, it broke the buildbots. Will investigate more. Change-Id: Ib6e33bb916b43b1a42f8f8e4c0c69eb360c3181c Reviewed-on: http://gerrit.chromium.org/gerrit/8332 Reviewed-by: Michael Krebs Tested-by: Michael Krebs --- crash_reporter/kernel_collector_test.cc | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/crash_reporter/kernel_collector_test.cc b/crash_reporter/kernel_collector_test.cc index 87c251b24..35bb0ec33 100644 --- a/crash_reporter/kernel_collector_test.cc +++ b/crash_reporter/kernel_collector_test.cc @@ -230,14 +230,15 @@ TEST_F(KernelCollectorTest, CollectNoCrash) { ASSERT_EQ(0, s_crashes); } -TEST_F(KernelCollectorTest, CollectBadDirectory) { - collector_.SetParameters(17, 0, 17); - WriteStringToFile(test_kcrash_, "====1.1\nsomething"); - ASSERT_TRUE(collector_.Collect()); - ASSERT_TRUE(FindLog( - "Unable to create appropriate crash directory")); - ASSERT_EQ(1, s_crashes); -} +// Disabled for crosbug.com/18622 +//TEST_F(KernelCollectorTest, CollectBadDirectory) { +// collector_.SetParameters(17, 0, 17); +// WriteStringToFile(test_kcrash_, "====1.1\nsomething"); +// ASSERT_TRUE(collector_.Collect()); +// ASSERT_TRUE(FindLog( +// "Unable to create appropriate crash directory")); +// ASSERT_EQ(1, s_crashes); +//} void KernelCollectorTest::SetUpSuccessfulCollect() { collector_.ForceCrashDirectory(kTestCrashDirectory);